PR is tearing down my elegant solution

Ya'll ever feel so proud of your elegant solution or novel code block? Then the PR comments basically say knock it down. While I understand why the code is being changed, it also hurts a little to break down and revise it to (in my perspective) something less elegant. Also because I spent a lot of thought orchestrating each line of that code

Low level example

my code: $sqlPassword = -join ((65..90) + (97..122) + (48..57) | Get-Random -Count 32 | % {[char]$_})

new code (imported from a common module in our repo): $sqlPassword = New-RandomPassword

submitted by /u/TuneTop9671
[link] [comments]

from Software Development – methodologies, techniques, and tools. Covering Agile, RUP, Waterfall + more! https://ift.tt/Hv6Fy3Z

Leave a comment

Design a site like this with WordPress.com
Get started
search previous next tag category expand menu location phone mail time cart zoom edit close