How do you make your teammates actually review your code?

We’re a team of 8 software engineers. Our previous (and sort of broken) workflow is as follows –

  • Dev opens a PR
  • Sends it to the team Slack channel
  • Wait for someone to pick it up
  • Starts pinging teammates

It’s not working that well. Devs would often get blocked by unmerged PRs, and some would even get lost in the channel, only to be remembered a few days later (and by then merge conflicts can arise, pipeline issues could come up, etc.)

We began expirimenting with a new approach –

  • Assigning PRs during daily standup to increase team accountability (everyone knows what they should review, and who they’re going to block if not)
  • Opening a Slack channel for each PR for discussions (this decluttres the main Slack channel and makes it harder for PRs to get lost in the void)

It’s working pretty well for us thus far (we actually automated it), and I was wondering – has anyone here encountered this problem as well?

What are your approach for dealing with this issue? How did you solve it for your team?

submitted by /u/SignalKit
[link] [comments]

from Software Development – methodologies, techniques, and tools. Covering Agile, RUP, Waterfall + more! https://ift.tt/1JbXEum

Leave a comment

Design a site like this with WordPress.com
Get started
search previous next tag category expand menu location phone mail time cart zoom edit close