Is my company slow at reviewing pull requests?

Hello there.

I'm here to ask you for an opinion and advice.
I'm a webdev, I work remotely for a company, and compared to some colleagues, I'm very very fast at working (but also in previous works I've been judged like so). I work in this company for almost 2 years. Here, pull requests take an average of 5 working days to get merged.

I want to specify that all my pull requests, and also my colleagues':

  1. Absolutely don't cross over 400 changed lines and 200 addition, here we have an average of 150 changed lines I think
  2. Well describe the problem and have also a link to the jira ticket
  3. Contain a list of actions to verify the quality of the pr (the bug is not there anymore or the feature's happy path)
  4. Have a preview web link to showcase the feature (so that people don't have to pull the changes locally and test themselves)

If it wasn't obvious to me 5 days is an eternity that brings my productivity down as hell.
More than a week ago I've opened 5 pull requests all in one day (just one of them was based on another pull request in that review batch): 2 were merged after 3 days, 2 after 5 days, and 1 is still in review 🤦

When I say 5 days, the process is the following:

  1. Usually, up to 3 days to have the first batch of comments and request changes from colleagues (then highly depends on the people reviewing my code. Some will just approve it, and others will fix grammar spelling, words casing, and so on)
  2. Even if I immediately apply the fixes (in a couple of hours top if the fixes are a lot) I gotta wait at least 1 or 2 days to get reviewed a second time and, usually, here is where the pr gets approved. If the reviewer is picky it can go even further.

I spoke to managers a lot about this who luckily have high consideration for me, but really is no easy thing to change. Especially because I don't want to make the workplace toxic by inspecting what people are doing all the time and coming out with bad stuff like "listen, haven't you really had 15 minutes to review this?".

Now I have two questions for you:

  1. Is this normal? If no šŸ‘‡
  2. What can I do to make some impact and make the review process fast and the workflow smooth?

submitted by /u/Sea_Roof_8906
[link] [comments]

from Software Development – methodologies, techniques, and tools. Covering Agile, RUP, Waterfall + more! https://ift.tt/0pULVvl

Leave a comment

Design a site like this with WordPress.com
Get started
search previous next tag category expand menu location phone mail time cart zoom edit close